Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160304128
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160303995
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160303876
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
Github user tomasatdatabricks commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160303763
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -143,12 +174,12 @@ object ImageSchema {
val hei
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160293894
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160293554
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160300141
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160294482
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160264983
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+def
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160294154
--- Diff: python/pyspark/ml/image.py ---
@@ -150,29 +194,27 @@ def toImage(self, array, origin=""):
"array argument should be numpy.ndarr
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160267784
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160267831
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160267553
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -143,12 +174,12 @@ object ImageSchema {
val height = img.g
Github user MrBago commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160291075
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since("2.3.0")
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160271945
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160264533
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160265175
--- Diff: python/pyspark/ml/image.py ---
@@ -55,7 +72,7 @@ def imageSchema(self):
"""
if self._imageSchema is None:
Github user WeichenXu123 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160264829
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160260468
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160259006
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -143,12 +174,12 @@ object ImageSchema {
val height
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160258674
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since("2.
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160257066
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160255996
--- Diff: python/pyspark/ml/tests.py ---
@@ -1843,6 +1844,28 @@ def tearDown(self):
class ImageReaderTest(SparkSessionTestCase):
+
Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160255634
--- Diff: python/pyspark/ml/image.py ---
@@ -201,8 +243,9 @@ def readImages(self, path, recursive=False,
numPartitions=-1,
.. versionadde
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016767
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016719
--- Diff: python/pyspark/ml/image.py ---
@@ -71,9 +88,30 @@ def ocvTypes(self):
"""
if self._ocvTypes is None:
-
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/20168#discussion_r160016683
--- Diff: mllib/src/main/scala/org/apache/spark/ml/image/ImageSchema.scala
---
@@ -37,20 +37,51 @@ import org.apache.spark.sql.types._
@Since("2.3.
GitHub user tomasatdatabricks opened a pull request:
https://github.com/apache/spark/pull/20168
SPARK-22730 Add ImageSchema support for non-integer image formats
## What changes were proposed in this pull request?
Added functionality to handle all OpenCV modes to ImageSchema:
28 matches
Mail list logo
