[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-12-02 Thread Ngone51
Github user Ngone51 commented on a diff in the pull request: https://github.com/apache/spark/pull/20269#discussion_r238135789 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -38,10 +38,13 @@ package object config {

[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-01-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20269 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-01-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20269#discussion_r161608661 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -419,7 +419,7 @@ package object config { private[spark] val

[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-01-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20269#discussion_r161609423 --- Diff: docs/configuration.md --- @@ -150,6 +152,7 @@ of the most common options to set are: Amount of memory to use for the driver

[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-01-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/20269#discussion_r161609127 --- Diff: docs/configuration.md --- @@ -58,6 +58,8 @@ The following format is accepted: 1t or 1tb (tebibytes = 1024 gibibytes) 1p or 1pb

[GitHub] spark pull request #20269: [SPARK-23029] [DOCS] Specifying default units of ...

2018-01-15 Thread ferdonline
GitHub user ferdonline opened a pull request: https://github.com/apache/spark/pull/20269 [SPARK-23029] [DOCS] Specifying default units of configuration entries ## What changes were proposed in this pull request? This PR completes the docs, specifying the default units assumed in