[GitHub] spark pull request #20324: [SPARK-23091][ML] Incorrect unit test for approxQ...

2018-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20324 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20324: [SPARK-23091][ML] Incorrect unit test for approxQ...

2018-01-18 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20324#discussion_r162547532 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameStatSuite.scala --- @@ -154,24 +154,24 @@ class DataFrameStatSuite extends QueryTest with

[GitHub] spark pull request #20324: [SPARK-23091][ML] Incorrect unit test for approxQ...

2018-01-18 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/20324 [SPARK-23091][ML] Incorrect unit test for approxQuantile ## What changes were proposed in this pull request? Narrow bound on approx quantile test to epsilon from 2*epsilon to match paper