Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r182820983
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/decimalExpressions.scala
---
@@ -80,30 +80,44 @@ case class PromotePreci
Github user bersprockets commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163269198
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -1074,6 +1074,16 @@ object SQLConf {
.booleanConf
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163184979
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163184915
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/decimalArithmeticOperations.sql ---
@@ -49,7 +49,6 @@ select 1e35 / 0.1;
-- arithmetic op
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163134873
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with
S
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163134537
--- Diff:
sql/core/src/test/resources/sql-tests/inputs/decimalArithmeticOperations.sql ---
@@ -49,7 +49,6 @@ select 1e35 / 0.1;
-- arithmetic oper
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163013386
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] wit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163008946
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r163007885
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] wit
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r162959471
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] with
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20350#discussion_r162957968
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala ---
@@ -237,14 +238,26 @@ final class Decimal extends Ordered[Decimal] wit
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20350
[SPARK-23179][SQL] Support option to throw exception if overflow occurs
## What changes were proposed in this pull request?
SQL ANSI 2011 states that in case of overflow during arithmetic
12 matches
Mail list logo
