Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20461
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20461#discussion_r165276461
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -171,7 +171,9 @@ private void failRemaini
Github user ConeyLiu commented on a diff in the pull request:
https://github.com/apache/spark/pull/20461#discussion_r165246022
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -171,7 +171,9 @@ private void failRemain
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/20461#discussion_r165225508
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -171,7 +171,9 @@ private void failRemaini
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/20461#discussion_r165213755
--- Diff:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/OneForOneBlockFetcher.java
---
@@ -171,7 +171,9 @@ private void failRemainin
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/20461
[SPARK-23289][CORE]OneForOneBlockFetcher.DownloadCallback.onData should
write the bufer fully
## What changes were proposed in this pull request?
`channel.write(buf)` may not write the who