[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-14 Thread rednaxelafx
Github user rednaxelafx commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r168101849 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -675,6 +675,16 @@ object SQLConf { "disable logging

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r168067551 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -1461,20 +1465,19 @@ object

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-13 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r168067521 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -675,6 +675,16 @@ object SQLConf { "disable logging

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-13 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r167960429 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala --- @@ -1461,20 +1465,19 @@ object CodeGenerator

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-13 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/20599#discussion_r167852572 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -675,6 +675,16 @@ object SQLConf { "disable logging or

[GitHub] spark pull request #20599: [SPARK-23407][SQL] add a config to try to inline ...

2018-02-13 Thread cloud-fan
GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/20599 [SPARK-23407][SQL] add a config to try to inline all mutable states during codegen ## What changes were proposed in this pull request? This is a followup of