Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168910218
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -414,16 +417,16 @@ class ParquetFileF
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168714722
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -395,16 +395,19 @@ class ParquetFil
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168711619
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -395,16 +395,19 @@ class ParquetF
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168709918
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -395,16 +395,19 @@ class ParquetFil
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168557092
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -414,16 +417,16 @@ class ParquetF
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168556797
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -414,16 +417,16 @@ class ParquetF
Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20619#discussion_r168552292
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -414,16 +417,16 @@ class ParquetFileForma
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/20619
[SPARK-23390][SQL] Register task completion listerners first in
ParquetFileFormat
## What changes were proposed in this pull request?
ParquetFileFormat leaks opened files in some cas
