[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/20886 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r179008019 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -298,15 +299,32 @@ class SessionCatalog(

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-03 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r179007898 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala --- @@ -1152,6 +1152,13 @@ object SQLConf { .booleanConf

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-01 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r178472405 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -298,15 +302,28 @@ class SessionCatalog(

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r178470268 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -298,15 +302,28 @@ class SessionCatalog(

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r178470264 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala --- @@ -298,15 +302,28 @@ class SessionCatalog(

[GitHub] spark pull request #20886: [SPARK-19724][SQL]create a managed table with an ...

2018-04-01 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/20886#discussion_r178470143 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala --- @@ -103,6 +103,60 @@ class InMemoryCatalogedDDLSuite