Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180785280
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180780184
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180762815
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180757449
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180749769
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180744472
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180738201
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180736396
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180735160
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180731575
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180731735
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180733854
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180731432
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180730577
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,166 @@
+/*
+ * Licensed to
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/21026
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180730181
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed to
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180598651
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -352,12 +346,10 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180596423
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/nullExpressions.scala
---
@@ -352,12 +346,10 @@ case class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180593331
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180575894
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala
---
@@ -107,7 +110,7 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180583517
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/javaCode.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Licensed
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180575717
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -292,8 +292,7 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180575964
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala
---
@@ -76,7 +78,7 @@ object
Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180575803
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateSafeProjection.scala
---
@@ -128,7 +131,7 @@ object
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180554710
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -331,7 +333,7 @@ class
Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/21026#discussion_r180468933
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -144,7 +144,7 @@ object
GitHub user hvanhovell opened a pull request:
https://github.com/apache/spark/pull/21026
[SPARK-23951][SQL] Use actual java class instead of string representation.
## What changes were proposed in this pull request?
This PR slightly refactors the newly added `ExprValue` API by
27 matches
Mail list logo
