[GitHub] spark pull request #21125: [Spark-24024][ML] Fix poisson deviance calculatio...

2018-04-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21125 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21125: [Spark-24024][ML] Fix poisson deviance calculatio...

2018-04-23 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183475337 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -782,8 +782,12 @@ object GeneralizedLinearRegression

[GitHub] spark pull request #21125: [Spark-24024][ML] Fix poisson deviance calculatio...

2018-04-23 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183386685 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -495,8 +495,8 @@ class GeneralizedLinearRegres

[GitHub] spark pull request #21125: [Spark-24024][ML] Fix poisson deviance calculatio...

2018-04-23 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183386571 --- Diff: mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala --- @@ -782,8 +782,12 @@ object GeneralizedLinearRegressio

[GitHub] spark pull request #21125: [Spark-24024][ML] Fix poisson deviance calculatio...

2018-04-23 Thread tengpeng
Github user tengpeng commented on a diff in the pull request: https://github.com/apache/spark/pull/21125#discussion_r183386022 --- Diff: mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala --- @@ -495,8 +495,8 @@ class GeneralizedLinearRegres