[GitHub] spark pull request #21164: [SPARK-24098][SQL] ScriptTransformationExec shoul...

2018-05-02 Thread liutang123
Github user liutang123 commented on a diff in the pull request: https://github.com/apache/spark/pull/21164#discussion_r185693669 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -137,13 +137,12 @@ case class ScriptTransfor

[GitHub] spark pull request #21164: [SPARK-24098][SQL] ScriptTransformationExec shoul...

2018-05-02 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/21164#discussion_r185511245 --- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/ScriptTransformationExec.scala --- @@ -137,13 +137,12 @@ case class ScriptTransform

[GitHub] spark pull request #21164: [SPARK-24098][SQL] ScriptTransformationExec shoul...

2018-04-26 Thread liutang123
GitHub user liutang123 opened a pull request: https://github.com/apache/spark/pull/21164 [SPARK-24098][SQL] ScriptTransformationExec should wait process exiting before output iterator finish When feed thread doesn't set its _exception variable and the progress doesn't exit complete