[GitHub] spark pull request #21244: [SPARK-24185][SparkR][SQL]add flatten function to...

2018-05-05 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/21244#discussion_r186278752 --- Diff: R/pkg/R/generics.R --- @@ -918,6 +918,10 @@ setGeneric("explode_outer", function(x) { standardGeneric("explode_outer") }) #' @name NULL

[GitHub] spark pull request #21244: [SPARK-24185][SparkR][SQL]add flatten function to...

2018-05-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21244 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21244: [SPARK-24185][SparkR][SQL]add flatten function to...

2018-05-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21244#discussion_r186276706 --- Diff: R/pkg/R/functions.R --- @@ -3035,6 +3036,19 @@ setMethod("array_position", column(jc) }) +#'

[GitHub] spark pull request #21244: [SPARK-24185][SparkR][SQL]add flatten function to...

2018-05-05 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/21244#discussion_r186276677 --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R --- @@ -1502,6 +1502,12 @@ test_that("column functions", { result <- collect(select(df,

[GitHub] spark pull request #21244: [SPARK-24185][SparkR][SQL]add flatten function to...

2018-05-05 Thread huaxingao
Github user huaxingao commented on a diff in the pull request: https://github.com/apache/spark/pull/21244#discussion_r186275756 --- Diff: R/pkg/R/generics.R --- @@ -918,6 +918,10 @@ setGeneric("explode_outer", function(x) { standardGeneric("explode_outer") }) #' @name NULL