[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/21425 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-26 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r191042262 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,71 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r191041927 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql --- @@ -0,0 +1,47 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-26 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r191041812 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,71 @@

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r191023831 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,97 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r191023845 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,97 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190951572 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,97 @@

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190934130 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,97 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190934095 --- Diff: sql/core/src/test/resources/sql-tests/results/subquery/in-subquery/not-in-unit-tests-multi-column-literal.sql.out --- @@ -0,0 +1,97 @@ +--

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190842619 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/not-in-unit-tests-single-column.sql --- @@ -0,0 +1,123 @@ +-- Unit tests

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190841865 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/not-in-unit-tests-single-column.sql --- @@ -0,0 +1,123 @@ +-- Unit

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread hvanhovell
Github user hvanhovell commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190841604 --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/concat.sql.out --- @@ -1,5 +1,5 @@ -- Automatically generated by

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190829076 --- Diff: sql/core/src/test/resources/sql-tests/inputs/subquery/in-subquery/not-in-unit-tests-single-column.sql --- @@ -0,0 +1,123 @@ +-- Unit tests

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-25 Thread mgyucht
Github user mgyucht commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190828822 --- Diff: sql/core/src/test/resources/sql-tests/results/typeCoercion/native/concat.sql.out --- @@ -1,5 +1,5 @@ -- Automatically generated by

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190697148 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190697379 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190695008 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190694495 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190694156 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with

[GitHub] spark pull request #21425: [SPARK-24381][TESTING] Add unit tests for NOT IN ...

2018-05-24 Thread gatorsmile
Github user gatorsmile commented on a diff in the pull request: https://github.com/apache/spark/pull/21425#discussion_r190680216 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SubquerySuite.scala --- @@ -275,6 +277,135 @@ class SubquerySuite extends QueryTest with