GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/21520
[SPARK-24505][SQL][WIP] Forbidding string interpolation in CodeBlock
## What changes were proposed in this pull request?
The code block interpolator currently accepts strings. Based on previous
discussion, we should forbid string interpolation to prevent losing references
to expressions (`ExprValue`) in code blocks.
## How was this patch tested?
Existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 SPARK-24505
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/21520.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #21520
----
commit 0f4fe62ce18b9ed7179940947ee737acde9376bd
Author: Liang-Chi Hsieh <viirya@...>
Date: 2018-05-23T06:32:12Z
Initial pass to forbid string interpolation.
commit d80a9485c1a6f5ce31ba4cf6203725d9f9db8623
Author: Liang-Chi Hsieh <viirya@...>
Date: 2018-06-09T10:08:52Z
Merge remote-tracking branch 'upstream/master' into SPARK-24505
commit a85ffe64e53ce728da5db6441392348a88816096
Author: Liang-Chi Hsieh <viirya@...>
Date: 2018-06-09T11:32:00Z
Second pass.
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
