GitHub user shaneknapp opened a pull request:

    https://github.com/apache/spark/pull/21864

    [SPARK-24908][R] removing spaces to make lintr happy

    ## What changes were proposed in this pull request?
    
    during my travails in porting spark builds to run on our centos worker, i 
managed to recreate (as best i could) the centos environment on our new 
ubuntu-testing machine.
    
    while running my initial builds, lintr was crashing on some extraneous 
spaces in test_basic.R (see:  
https://amplab.cs.berkeley.edu/jenkins/job/spark-master-test-sbt-hadoop-2.6-ubuntu-test/862/console)
    
    after removing those spaces, the ubuntu build happily passed the lintr 
tests.
    
    ## How was this patch tested?
    
    i then tested this against a modified spark-master-test-sbt-hadoop-2.6 
build (see 
https://amplab.cs.berkeley.edu/jenkins/view/RISELab%20Infra/job/testing-spark-master-test-with-updated-R-crap/4/),
 which scp'ed a copy of test_basic.R in to the repo after the git clone.  
everything seems to be working happily.
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shaneknapp/spark fixing-R-lint-spacing

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21864.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21864
    
----
commit 81eaa2ac66311bda91f5c47adc7c7ee47e0b0d6f
Author: shane knapp <incomplete@...>
Date:   2018-07-24T17:23:02Z

    remove spaces and make lintr happy

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to