GitHub user cloud-fan opened a pull request: https://github.com/apache/spark/pull/21966
simplify codegen of array_except ## What changes were proposed in this pull request? simplify the codegen: 1. only do real codegen if the type can be specialized by the hash set 2. change the null handling. Before: track the nullElementIndex, and create a new ArrayData to insert the null in the middle. After: track the nullElementIndex, put a null placeholder in the ArrayBuilder, at the end create ArrayData from ArrayBuilder directly. ## How was this patch tested? existing tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloud-fan/spark minor2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/21966.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #21966 ---- commit 313ad294ec07d54f06db92f635b6bb9a76f17343 Author: Wenchen Fan <wenchen@...> Date: 2018-08-02T09:18:21Z simplify codegen of array_except ---- --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org