[GitHub] spark pull request #22058: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not...

2018-08-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22058 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22058: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not...

2018-08-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22058#discussion_r209027132 --- Diff: mllib/src/main/scala/org/apache/spark/ml/evaluation/ClusteringEvaluator.scala --- @@ -119,6 +119,8 @@ class ClusteringEvaluator @Since("2.3.0")

[GitHub] spark pull request #22058: [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not...

2018-08-09 Thread kiszk
GitHub user kiszk opened a pull request: https://github.com/apache/spark/pull/22058 [SPARK-25036][SQL][FOLLOW-UP] Avoid match may not be exhaustive in Scala-2.12. ## What changes were proposed in this pull request? This is a follow-up pr of #22014 and #22039 We