[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22094 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209826949 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala --- @@ -72,62 +73,70 @@ class AvroSerializer(rootCatalystType:

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209811887 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala --- @@ -72,62 +73,70 @@ class AvroSerializer(rootCatalystType:

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209810245 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -850,6 +851,62 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209810119 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala --- @@ -212,7 +222,7 @@ class AvroSerializer(rootCatalystType:

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209780290 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -850,6 +851,62 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209779455 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -850,6 +851,62 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22094: [SPARK-25104][SQL]Avro: Validate user specified o...

2018-08-13 Thread dbtsai
Github user dbtsai commented on a diff in the pull request: https://github.com/apache/spark/pull/22094#discussion_r209750701 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/AvroSerializer.scala --- @@ -72,62 +73,70 @@ class AvroSerializer(rootCatalystType: