Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22106
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r211035290
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaTestUtils.scala
---
@@ -120,61 +120,56 @@ private[kafka010] class Kaf
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r211031056
--- Diff:
external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaTestUtils.scala
---
@@ -120,61 +120,56 @@ private[kafka010] class Kafk
Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r211030720
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
---
@@ -130,6 +130,13 @@ class KafkaTestUtils(withBroker
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r210977997
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/CachedKafkaProducer.scala
---
@@ -33,8 +33,12 @@ private[kafka010] object Ca
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r210387003
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaContinuousSinkSuite.scala
---
@@ -40,12 +40,7 @@ class KafkaContinuousS
Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22106#discussion_r210383608
--- Diff:
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaContinuousReader.scala
---
@@ -216,7 +216,7 @@ class KafkaContinuousInp
GitHub user zsxwing opened a pull request:
https://github.com/apache/spark/pull/22106
[SPARK-25116][Tests]Fix the kafka cluster leak and clean up cached producers
## What changes were proposed in this pull request?
KafkaContinuousSinkSuite leaks a Kafka cluster because both
