[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-11-28 Thread sujithjay
Github user sujithjay commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r236992453 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1058,31 +1064,37 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread sujithjay
Github user sujithjay commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211695230 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1058,31 +1064,37 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211619140 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1058,31 +1064,37 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211607297 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -975,8 +979,10 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211609440 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1028,23 +1034,23 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread sujithjay
Github user sujithjay commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211579406 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1099,7 +,7 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread maropu
Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22168#discussion_r211577003 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala --- @@ -1099,7 +,7 @@ private class

[GitHub] spark pull request #22168: [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Joi...

2018-08-21 Thread sujithjay
GitHub user sujithjay opened a pull request: https://github.com/apache/spark/pull/22168 [SPARK-24985][SQL][WIP] Fix OOM in Full Outer Join in case of data skew ## What issue does this pull request address ? JIRA: