[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22240#discussion_r212863571 --- Diff: core/src/main/scala/org/apache/spark/rdd/RDDBarrier.scala --- @@ -22,15 +22,22 @@ import scala.reflect.ClassTag import

[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22240#discussion_r212863543 --- Diff: core/src/main/scala/org/apache/spark/BarrierTaskInfo.scala --- @@ -28,4 +28,4 @@ import org.apache.spark.annotation.{Experimental, Since} */

[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22240#discussion_r212863507 --- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala --- @@ -21,25 +21,31 @@ import java.util.{Properties, Timer, TimerTask}

[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22240#discussion_r212863444 --- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala --- @@ -68,7 +74,7 @@ class BarrierTaskContext( * * CAUTION! In a

[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/22240#discussion_r212863381 --- Diff: core/src/main/scala/org/apache/spark/BarrierTaskContext.scala --- @@ -21,25 +21,31 @@ import java.util.{Properties, Timer, TimerTask}

[GitHub] spark pull request #22240: [WIP] [SPARK-25248] [CORE] Audit barrier APIs for...

2018-08-26 Thread mengxr
GitHub user mengxr opened a pull request: https://github.com/apache/spark/pull/22240 [WIP] [SPARK-25248] [CORE] Audit barrier APIs for 2.4 ## What changes were proposed in this pull request? I made one pass over barrier APIs added to Spark 2.4 and updates some scopes and