[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22251 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213407599 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213407441 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213233392 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread HyukjinKwon
Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213232867 --- Diff: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala --- @@ -1099,6 +1098,27 @@ class AvroSuite extends QueryTest with

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22251#discussion_r213231887 --- Diff: external/avro/src/main/scala/org/apache/spark/sql/avro/SchemaConverters.scala --- @@ -143,29 +143,25 @@ object SchemaConverters {

[GitHub] spark pull request #22251: [SPARK-25260][SQL] Fix namespace handling in Sche...

2018-08-28 Thread arunmahadevan
GitHub user arunmahadevan opened a pull request: https://github.com/apache/spark/pull/22251 [SPARK-25260][SQL] Fix namespace handling in SchemaConverters.toAvroType ## What changes were proposed in this pull request? `toAvroType` converts spark data type to avro schema. It