[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22259#discussion_r213701008 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2149,28 +2149,34 @@ class Analyzer(

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22259#discussion_r213699237 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2149,28 +2149,34 @@ class Analyzer(

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22259#discussion_r213689172 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2149,28 +2149,34 @@ class Analyzer(

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22259 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread cloud-fan
Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22259#discussion_r213570418 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2149,28 +2149,34 @@ class Analyzer(

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-29 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22259#discussion_r213569142 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -2149,28 +2149,34 @@ class Analyzer(

[GitHub] spark pull request #22259: [WIP][SPARK-25044][SQL] (take 2) Address translat...

2018-08-28 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22259 [WIP][SPARK-25044][SQL] (take 2) Address translation of LMF closure primitive args to Object in Scala 2.12 ## What changes were proposed in this pull request? Alternative take on