[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22337 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-10 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216418822 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -50,8 +50,11 @@ class StreamingAggregationSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216174661 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/FlatMapGroupsWithStateSuite.scala --- @@ -54,8 +54,11 @@ class

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216174637 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingDeduplicationSuite.scala --- @@ -31,8 +31,11 @@ class

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-09 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216174605 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingAggregationSuite.scala --- @@ -50,8 +50,11 @@ class

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-08 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216130925 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/WideSchemaBenchmark.scala --- @@ -54,8 +54,11 @@ class WideSchemaBenchmark

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216120896 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -49,8 +49,11 @@ class StateStoreRDDSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216120459 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -49,8 +49,11 @@ class

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216120240 --- Diff: external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaRDDSuite.scala --- @@ -44,20 +44,25 @@ class KafkaRDDSuite extends

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216120228 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaRelationSuite.scala --- @@ -51,8 +51,8 @@ class KafkaRelationSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread kiszk
Github user kiszk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216119902 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -49,8 +49,11 @@ class StateStoreRDDSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216114963 --- Diff: external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaRDDSuite.scala --- @@ -44,20 +44,25 @@ class KafkaRDDSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread holdenk
Github user holdenk commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216114084 --- Diff: external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaRDDSuite.scala --- @@ -44,20 +44,25 @@ class KafkaRDDSuite extends

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216034900 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala --- @@ -49,8 +49,11 @@ class

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216033347 --- Diff: external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/KafkaStreamSuite.scala --- @@ -35,19 +35,24 @@ class KafkaStreamSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216033251 --- Diff: external/kafka-0-8/src/test/scala/org/apache/spark/streaming/kafka/KafkaRDDSuite.scala --- @@ -35,20 +35,25 @@ class KafkaRDDSuite extends

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216033138 --- Diff: external/kafka-0-10/src/test/scala/org/apache/spark/streaming/kafka010/KafkaRDDSuite.scala --- @@ -44,20 +44,25 @@ class KafkaRDDSuite

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216032657 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaSinkSuite.scala --- @@ -51,8 +51,8 @@ class KafkaSinkSuite extends

[GitHub] spark pull request #22337: [SPARK-25338][Test] Ensure to call super.beforeAl...

2018-09-07 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22337#discussion_r216032535 --- Diff: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaRelationSuite.scala --- @@ -51,8 +51,8 @@ class KafkaRelationSuite