[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22356 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22356#discussion_r215749840 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -299,6 +301,25 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22356#discussion_r215737907 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -299,6 +301,25 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22356#discussion_r215737727 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -299,6 +301,25 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22356#discussion_r215730938 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -299,6 +301,25 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread imatiach-msft
Github user imatiach-msft commented on a diff in the pull request: https://github.com/apache/spark/pull/22356#discussion_r215730668 --- Diff: core/src/test/scala/org/apache/spark/FileSuite.scala --- @@ -299,6 +301,25 @@ class FileSuite extends SparkFunSuite with LocalSparkContext {

[GitHub] spark pull request #22356: [SPARK-22357][CORE][FOLLOWUP] SparkContext.binary...

2018-09-06 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/spark/pull/22356 [SPARK-22357][CORE][FOLLOWUP] SparkContext.binaryFiles ignore minPartitions parameter ## What changes were proposed in this pull request? This adds a test following https://github.com/apach