[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-11 Thread ConeyLiu
Github user ConeyLiu closed the pull request at: https://github.com/apache/spark/pull/22371 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216389817 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +154,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-10 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216387272 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +154,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-10 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216383808 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +154,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-10 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216369925 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +154,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-10 Thread ConeyLiu
Github user ConeyLiu commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216304910 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -51,6 +52,8 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216167054 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +148,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216167356 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -138,13 +148,22 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216166979 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -51,6 +52,8 @@ private[spark] class IndexShuffleBlockResolver(

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-09 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22371#discussion_r216167004 --- Diff: core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala --- @@ -76,6 +79,13 @@ private[spark] class

[GitHub] spark pull request #22371: [SPARK-25386][CORE] Don't need to synchronize the...

2018-09-09 Thread ConeyLiu
GitHub user ConeyLiu opened a pull request: https://github.com/apache/spark/pull/22371 [SPARK-25386][CORE] Don't need to synchronize the IndexShuffleBlockResolver for each writeIndexFileAndCommit ## What changes were proposed in this pull request? Now, we need