[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-28 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r221212734 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer( Cast(v

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22519 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-27 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r221090624 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer( Cast

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219667782 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer( Cast(v

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-22 Thread mgaido91
Github user mgaido91 commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219667780 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,11 @@ class Analyzer( Cast(v

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219624150 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,10 @@ class Analyzer( Cast

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219624067 --- Diff: sql/core/src/test/resources/sql-tests/inputs/pivot.sql --- @@ -287,3 +287,13 @@ PIVOT ( sum(earnings) FOR (course, m) IN (('dotNET

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread maryannxue
Github user maryannxue commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219623907 --- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out --- @@ -1,5 +1,5 @@ --- Automatically generated by SQLQueryTestSuite --- Num

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219615082 --- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out --- @@ -1,5 +1,5 @@ --- Automatically generated by SQLQueryTestSuite --- Number

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219614494 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -554,8 +554,10 @@ class Analyzer( Cast(va

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread MaxGekk
Github user MaxGekk commented on a diff in the pull request: https://github.com/apache/spark/pull/22519#discussion_r219614891 --- Diff: sql/core/src/test/resources/sql-tests/inputs/pivot.sql --- @@ -287,3 +287,13 @@ PIVOT ( sum(earnings) FOR (course, m) IN (('dotNET',

[GitHub] spark pull request #22519: [SPARK-25505][SQL] The output order of grouping c...

2018-09-21 Thread maryannxue
GitHub user maryannxue opened a pull request: https://github.com/apache/spark/pull/22519 [SPARK-25505][SQL] The output order of grouping columns in Pivot is different from the input order ## What changes were proposed in this pull request? The grouping columns from a Pivot