Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22557
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22557#discussion_r221067971
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/crypto/AuthEngine.java
---
@@ -241,29 +249,52 @@ private SecretKeySpec generateKey(St
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22557#discussion_r221067787
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/crypto/AuthEngine.java
---
@@ -241,29 +249,52 @@ private SecretKeySpec generateKey(St
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22557#discussion_r221056816
--- Diff:
core/src/main/scala/org/apache/spark/security/CryptoStreamUtils.scala ---
@@ -157,6 +165,111 @@ private[spark] object CryptoStreamUtils extends
Lo
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22557#discussion_r221058039
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/crypto/AuthEngine.java
---
@@ -241,29 +249,52 @@ private SecretKeySpec generateKey(St
Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22557#discussion_r221056128
--- Diff:
core/src/test/scala/org/apache/spark/security/CryptoStreamUtilsSuite.scala ---
@@ -164,6 +167,34 @@ class CryptoStreamUtilsSuite extends SparkFunSu
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/22557
[SPARK-25535][core] Work around bad error handling in commons-crypto.
The commons-crypto library does some questionable error handling internally,
which can lead to JVM crashes if some call into
