[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220757765 --- Diff: examples/src/main/scala/org/apache/spark/examples/jdbc/PluggableConnectionFactoryExample.scala --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220757697 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala --- @@ -65,4 +67,60 @@ class JdbcUtilsSuite

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220756677 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala --- @@ -65,4 +67,60 @@ class JdbcUtilsSuite

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dilipbiswal
Github user dilipbiswal commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220751466 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtilsSuite.scala --- @@ -65,4 +67,60 @@ class JdbcUtilsSuite

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220748468 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -186,6 +187,11 @@ class JDBCOptions(

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220748546 --- Diff: examples/src/main/scala/org/apache/spark/examples/jdbc/PluggableConnectionFactoryExample.scala --- @@ -0,0 +1,76 @@ +/* + *

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220748131 --- Diff: examples/src/main/scala/org/apache/spark/examples/jdbc/PluggableConnectionFactoryExample.scala --- @@ -0,0 +1,76 @@ +/* + * Licensed to

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220734063 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -40,28 +40,45 @@ import

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
Github user fsauer65 commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220733406 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -186,6 +187,11 @@ class JDBCOptions(

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220733266 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala --- @@ -40,28 +40,45 @@ import

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220733010 --- Diff: examples/src/main/scala/org/apache/spark/examples/jdbc/PluggableConnectionFactoryExample.scala --- @@ -0,0 +1,76 @@ +/* + *

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22560#discussion_r220732627 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala --- @@ -186,6 +187,11 @@ class JDBCOptions(

[GitHub] spark pull request #22560: [SPARK-25547][Spark Core] Pluggable JDBC connecti...

2018-09-26 Thread fsauer65
GitHub user fsauer65 opened a pull request: https://github.com/apache/spark/pull/22560 [SPARK-25547][Spark Core] Pluggable JDBC connection factory ## What changes were proposed in this pull request? Allow for pluggable connection factories in the spark jdbc package.