[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22582 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22582#discussion_r221413500 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -556,7 +556,7 @@ class Analyzer( // Group-by

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread viirya
Github user viirya commented on a diff in the pull request: https://github.com/apache/spark/pull/22582#discussion_r221413483 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala --- @@ -556,7 +556,7 @@ class Analyzer( // Group-by

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22582#discussion_r221409258 --- Diff: sql/core/src/test/resources/sql-tests/inputs/pivot.sql --- @@ -297,3 +297,13 @@ PIVOT ( sum(earnings) FOR course IN ('dotNET',

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22582#discussion_r221409166 --- Diff: sql/core/src/test/resources/sql-tests/inputs/pivot.sql --- @@ -297,3 +297,13 @@ PIVOT ( sum(earnings) FOR course IN ('dotNET',

[GitHub] spark pull request #22582: [SPARK-25505][SQL][FOLLOWUP] Fix for attributes c...

2018-09-28 Thread mgaido91
GitHub user mgaido91 opened a pull request: https://github.com/apache/spark/pull/22582 [SPARK-25505][SQL][FOLLOWUP] Fix for attributes cosmetically different in Pivot clause ## What changes were proposed in this pull request? #22519 introduced a bug when the attributes in t