[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...

2018-10-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22599 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...

2018-10-01 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22599#discussion_r221637241 --- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala --- @@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStre

[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...

2018-10-01 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22599#discussion_r221636295 --- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala --- @@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStre

[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...

2018-10-01 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22599#discussion_r221634009 --- Diff: core/src/test/scala/org/apache/spark/benchmark/BenchmarkBase.scala --- @@ -25,7 +25,10 @@ import java.io.{File, FileOutputStream, OutputStre

[GitHub] spark pull request #22599: [SPARK-25581][SQL] Rename method `benchmark` as `...

2018-10-01 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22599 [SPARK-25581][SQL] Rename method `benchmark` as `benchmarkSuite` in `BenchmarkBase` ## What changes were proposed in this pull request? Rename method `benchmark` in `BenchmarkBase` a