[GitHub] spark pull request #22637: [SPARK-25408] Move to mode ideomatic Java8

2018-10-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223102153 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleSecuritySuite.java --- @@ -96,14 +96,16 @@ private

[GitHub] spark pull request #22637: [SPARK-25408] Move to mode ideomatic Java8

2018-10-05 Thread dongjoon-hyun
Github user dongjoon-hyun commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r223101514 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleBlockResolverSuite.java --- @@ -98,19 +98,19 @@

[GitHub] spark pull request #22637: [SPARK-25408] Move to mode ideomatic Java8

2018-10-04 Thread Fokko
Github user Fokko commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r222893178 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java --- @@ -133,37 +133,38 @@ private

[GitHub] spark pull request #22637: [SPARK-25408] Move to mode ideomatic Java8

2018-10-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r222892548 --- Diff: common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleIntegrationSuite.java --- @@ -133,37 +133,38 @@ private

[GitHub] spark pull request #22637: [SPARK-25408] Move to mode ideomatic Java8

2018-10-04 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22637#discussion_r222892759 --- Diff: sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/CLIService.java --- @@ -154,6 +154,7 @@ public synchronized void start() {