[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22683#discussion_r239482033 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/NullExpressionsSuite.scala --- @@ -160,7 +160,7 @@ class

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22683#discussion_r239480795 --- Diff: core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala --- @@ -62,14 +62,14 @@ class KryoSerializer(conf: SparkConf) if

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-12-06 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22683#discussion_r239481508 --- Diff: docs/sql-programming-guide.md --- @@ -4,10 +4,15 @@ displayTitle: Spark SQL, DataFrames and Datasets Guide title: Spark SQL and DataFrames

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-12-03 Thread httfighter
Github user httfighter commented on a diff in the pull request: https://github.com/apache/spark/pull/22683#discussion_r238215152 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1164,17 +1164,17 @@ private[spark] object Utils extends Logging { } else

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-12-02 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22683#discussion_r238102080 --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala --- @@ -1164,17 +1164,17 @@ private[spark] object Utils extends Logging { } else {

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-11-24 Thread httfighter
GitHub user httfighter reopened a pull request: https://github.com/apache/spark/pull/22683 [SPARK-25696] The storage memory displayed on spark Application UI is… … incorrect. ## What changes were proposed in this pull request? In the reported heartbeat information,

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-11-24 Thread httfighter
Github user httfighter closed the pull request at: https://github.com/apache/spark/pull/22683 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail:

[GitHub] spark pull request #22683: [SPARK-25696] The storage memory displayed on spa...

2018-10-10 Thread httfighter
GitHub user httfighter opened a pull request: https://github.com/apache/spark/pull/22683 [SPARK-25696] The storage memory displayed on spark Application UI is… … incorrect. ## What changes were proposed in this pull request? Change the cardinality of the unit