[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22727 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-16 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225418151 --- Diff: sbin/start-thriftserver.sh --- @@ -39,6 +39,10 @@ function usage { pattern+="\|Spark Command: " pattern+="\|==="

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-16 Thread felixcheung
Github user felixcheung commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225417566 --- Diff: sbin/start-thriftserver.sh --- @@ -39,6 +39,10 @@ function usage { pattern+="\|Spark Command: " pattern+="\|==="

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-15 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225392908 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala --- @@ -71,6 +71,12 @@ object

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-15 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225179121 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala --- @@ -71,6 +71,12 @@ object

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-15 Thread gengliangwang
Github user gengliangwang commented on a diff in the pull request: https://github.com/apache/spark/pull/22727#discussion_r225175351 --- Diff: sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2.scala --- @@ -71,6 +71,12 @@ object

[GitHub] spark pull request #22727: [SPARK-25735][CORE][MINOR]Improve start-thriftser...

2018-10-15 Thread gengliangwang
GitHub user gengliangwang opened a pull request: https://github.com/apache/spark/pull/22727 [SPARK-25735][CORE][MINOR]Improve start-thriftserver.sh: print clean usage and exit with code 1 ## What changes were proposed in this pull request? Currently if we run ``` sh