[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/22751 --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org

[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22751#discussion_r225708901 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ResourceRequestHelperSuite.scala --- @@ -163,52 +134,6 @@ class ResourceRequest

[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-16 Thread vanzin
Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22751#discussion_r225708545 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -372,6 +358,35 @@ class ClientSuite extends SparkFunSu

[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-16 Thread squito
Github user squito commented on a diff in the pull request: https://github.com/apache/spark/pull/22751#discussion_r225707336 --- Diff: resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala --- @@ -372,6 +358,35 @@ class ClientSuite extends SparkFunSu

[GitHub] spark pull request #22751: [SPARK-20327][yarn] Follow up: fix resource reque...

2018-10-16 Thread vanzin
GitHub user vanzin opened a pull request: https://github.com/apache/spark/pull/22751 [SPARK-20327][yarn] Follow up: fix resource request tests on Hadoop 3. The test fix is to allocate a `Resource` object only after the resource types have been initialized. Otherwise the YARN clas