Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22897
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230491208
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -96,22 +96,6 @@ case "$SPARK_K8S_CMD" in
"$@"
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230476657
--- Diff:
resource-managers/kubernetes/docker/src/main/dockerfiles/spark/entrypoint.sh ---
@@ -96,22 +96,6 @@ case "$SPARK_K8S_CMD" in
"$@"
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230469595
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,134 @@
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230438567
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,134 @@
+/*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230438469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13 @@ priva
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230428297
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13 @@ p
Github user liyinan926 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230429059
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,134 @@
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230181127
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230169913
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/*
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230167668
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230137873
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13 @@ priva
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230131792
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230131315
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230130484
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -47,10 +48,24 @@ private
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230130812
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/*
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230130335
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13 @@ priva
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230119272
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230115856
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicDriverFeatureStep.scala
---
@@ -47,10 +48,24 @@ privat
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230119092
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
---
@@ -0,0 +1,137 @@
+/
Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22897#discussion_r230115469
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
---
@@ -58,16 +58,13 @@ priv
GitHub user vanzin opened a pull request:
https://github.com/apache/spark/pull/22897
[SPARK-25875][k8s] Merge code to set up driver command into a single step.
Right now there are 3 different classes dealing with building the driver
command to run inside the pod, one for each "bi
22 matches
Mail list logo
