[GitHub] spark pull request #23225: [MINOR][CORE]Don't need to create an empty spill ...

2018-12-05 Thread heary-cao
Github user heary-cao commented on a diff in the pull request: https://github.com/apache/spark/pull/23225#discussion_r239305307 --- Diff: core/src/main/java/org/apache/spark/shuffle/sort/ShuffleExternalSorter.java --- @@ -167,64 +167,67 @@ private void writeSortedFile(boolean

[GitHub] spark pull request #23225: [MINOR][CORE]Don't need to create an empty spill ...

2018-12-05 Thread wangjiaochun
GitHub user wangjiaochun opened a pull request: https://github.com/apache/spark/pull/23225 [MINOR][CORE]Don't need to create an empty spill file when memory has no records ## What changes were proposed in this pull request? If there are no records in memory, then we don't need