squito commented on issue #23617: [SPARK-26680][SQL] Eagerly create inputVars while conditions are appropriate URL: https://github.com/apache/spark/pull/23617#issuecomment-456529763 aside from sean's comments, lgtm. Also cc @hvanhovell since you reviewed https://github.com/apache/spark/pull/22789 for SPARK-25767
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org