Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-04-21 Thread via GitHub
EnricoMi closed pull request #45664: [MINOR] Improve SparkPi example URL: https://github.com/apache/spark/pull/45664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-04-21 Thread via GitHub
EnricoMi commented on PR #45664: URL: https://github.com/apache/spark/pull/45664#issuecomment-2067958222 Thanks for the input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-04-20 Thread via GitHub
dongjoon-hyun commented on PR #45664: URL: https://github.com/apache/spark/pull/45664#issuecomment-2067877239 Sorry but I don't think this is a kind of `[MINOR]` category work item and I'm not sure about the contribution of this PR, @EnricoMi . Instead, I believe this example is very

Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-04-20 Thread via GitHub
EnricoMi commented on PR #45664: URL: https://github.com/apache/spark/pull/45664#issuecomment-2067659018 @dongjoon-hyun https://github.com/apache/spark/pull/45664#issuecomment-2016909814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-03-24 Thread via GitHub
HyukjinKwon commented on PR #45664: URL: https://github.com/apache/spark/pull/45664#issuecomment-2016995240 ![Screenshot 2024-03-25 at 8 50 51  AM](https://github.com/apache/spark/assets/6477701/f8d11d62-2c0e-44a8-ab1c-1ab23c69b029) According to the structure, it should be RDD/Core

Re: [PR] [MINOR] Improve SparkPi example [spark]

2024-03-24 Thread via GitHub
EnricoMi commented on PR #45664: URL: https://github.com/apache/spark/pull/45664#issuecomment-2016909814 @dongjoon-hyun what do you think about the partitions option? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [MINOR] Improve SparkPi example [spark]

2024-03-22 Thread via GitHub
EnricoMi opened a new pull request, #45664: URL: https://github.com/apache/spark/pull/45664 ### What changes were proposed in this pull request? - Make `SparkPi` example use Dataset API - Allow setting partition size - Print available options ### Why are the changes needed?