github-actions[bot] closed pull request #44581: [SPARK-46589][CONNECT] Handle a
non-existent error class
URL: https://github.com/apache/spark/pull/44581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-2053816398
We're closing this PR because it hasn't been updated in a while. This isn't
a judgement on the merit of the PR in any way. It's just a way of keeping the
PR queue manageable.
MaxGekk commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1877121814
> It's more scary to lose the error class name and parameters, which are
likely consumed by programs.
This is arguable. I guess user's code probably depends on `SQLSTATE` and
cloud-fan commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1877108169
> You propose to relax all the checks, so, anyone could create exception
with any garbage, and we cannot stop that.
I don't think that's an issue. We still require an error
cloud-fan commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1877105969
It's more scary to lose the error class name and parameters, which are
likely consumed by programs. We should at least use a dedicated java exception
to carry the error class name,
MaxGekk commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1877091968
> I think the best option is to instantiate the corresponding java exception
with error class name, error parameters and the full message.
This require to change behaviour of all
cloud-fan commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1877081007
error class and error parameters are part of the API. It's better to retain
them as well.
I think the best option is to instantiate the corresponding java exception
with error
cloud-fan commented on code in PR #44581:
URL: https://github.com/apache/spark/pull/44581#discussion_r1441728982
##
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##
@@ -369,6 +369,14 @@ private[client] object
heyihong commented on code in PR #44581:
URL: https://github.com/apache/spark/pull/44581#discussion_r1441699158
##
connector/connect/common/src/main/scala/org/apache/spark/sql/connect/client/GrpcExceptionConverter.scala:
##
@@ -380,9 +388,19 @@ private[client] object
MaxGekk commented on PR #44581:
URL: https://github.com/apache/spark/pull/44581#issuecomment-1876640296
@heyihong @cloud-fan @HyukjinKwon Please, review this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
10 matches
Mail list logo
