Re: [PR] [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions [spark]

2024-04-21 Thread via GitHub
planga82 commented on PR #45894: URL: https://github.com/apache/spark/pull/45894#issuecomment-2067982861 Thank you @zml1206 . I saw that you have proposed other solution. I'm going to close this PR -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions [spark]

2024-04-21 Thread via GitHub
planga82 closed pull request #45894: [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions URL: https://github.com/apache/spark/pull/45894 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions [spark]

2024-04-19 Thread via GitHub
zml1206 commented on code in PR #45894: URL: https://github.com/apache/spark/pull/45894#discussion_r1571913735 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala: ## @@ -193,7 +193,9 @@ class EquivalentExpressions( if

Re: [PR] [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions [spark]

2024-04-11 Thread via GitHub
planga82 commented on PR #45894: URL: https://github.com/apache/spark/pull/45894#issuecomment-2050682342 CC @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] [SPARK-46632][SQL] EquivalentExpressions addExprTree should allow all type of expressions [spark]

2024-04-05 Thread via GitHub
planga82 opened a new pull request, #45894: URL: https://github.com/apache/spark/pull/45894 ### What changes were proposed in this pull request? When we try to add some expressions to equivalent expressions it fail ``` import