Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-05-06 Thread via GitHub
pan3793 commented on PR #45372: URL: https://github.com/apache/spark/pull/45372#issuecomment-2096665513 @dongjoon-hyun thanks for checking, updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-05-06 Thread via GitHub
dongjoon-hyun commented on PR #45372: URL: https://github.com/apache/spark/pull/45372#issuecomment-2096652579 Could you update the PR description with RC1 link, @pan3793 ? - https://lists.apache.org/thread/3ton9oxlkkb1v7tbqqw1rhjpz9y8ymv5 -- This is an automated message from the Apache

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-22 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1575536345 ## dev/test-dependencies.sh: ## @@ -49,7 +49,7 @@ OLD_VERSION=$($MVN -q \ --non-recursive \ org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -E

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1575140785 ## dev/test-dependencies.sh: ## @@ -49,7 +49,7 @@ OLD_VERSION=$($MVN -q \ --non-recursive \ org.codehaus.mojo:exec-maven-plugin:1.6.0:exec | grep -E

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on PR #45372: URL: https://github.com/apache/spark/pull/45372#issuecomment-2070373629 For Docker Integration test dependency, I made the following PR with @pan3793 's authorship. - https://github.com/apache/spark/pull/46167 -- This is an automated message from

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-22 Thread via GitHub
dongjoon-hyun commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1575125465 ## project/SparkBuild.scala: ## @@ -952,7 +955,7 @@ object Unsafe { object DockerIntegrationTests { // This serves to override the override specified in

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-22 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574342250 ## common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala: ## @@ -192,6 +192,13 @@ private[spark] object MavenUtils extends Logging {

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574144603 ## sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala: ## @@ -1626,6 +1625,7 @@ class HiveQuerySuite extends HiveComparisonTest with

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574143381 ## sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala: ## @@ -1627,10 +1627,8 @@ class HiveQuerySuite extends HiveComparisonTest with

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574127899 ## sql/hive/src/test/java/org/apache/spark/sql/hive/test/Complex.java: ## @@ -16,7 +16,7 @@ */ package org.apache.spark.sql.hive.test; -import

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574116717 ## sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala: ## @@ -1626,6 +1625,7 @@ class HiveQuerySuite extends HiveComparisonTest with

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574116295 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ## @@ -3748,7 +3748,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
pan3793 commented on PR #45372: URL: https://github.com/apache/spark/pull/45372#issuecomment-2068475033 @dongjoon-hyun This one is mostly for verification, let's try any ideas on it. I plan to split it into several PRs once Hive 2.3.10 is officially released. -- This is an automated

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574094232 ## sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveQuerySuite.scala: ## @@ -1626,6 +1625,7 @@ class HiveQuerySuite extends HiveComparisonTest

Re: [PR] [SPARK-47018][BUILD] Upgrade built-in Hive to 2.3.10 [spark]

2024-04-21 Thread via GitHub
dongjoon-hyun commented on code in PR #45372: URL: https://github.com/apache/spark/pull/45372#discussion_r1574093194 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ## @@ -3748,7 +3748,7 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession with