cloud-fan closed pull request #45382: [SPARK-47248][SQL][COLLATION] Improved
string function support: contains
URL: https://github.com/apache/spark/pull/45382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
cloud-fan commented on PR #45382:
URL: https://github.com/apache/spark/pull/45382#issuecomment-1983758947
The GA jobs all passed:
https://github.com/uros-db/spark/actions/runs/8186876833/job/22395549669
merging to master, thanks!
--
This is an automated message from the Apache Git
uros-db commented on code in PR #45382:
URL: https://github.com/apache/spark/pull/45382#discussion_r1515579768
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -145,6 +149,18 @@ public Collation(
}
}
+ /**
+ * Auxiliary
cloud-fan commented on code in PR #45382:
URL: https://github.com/apache/spark/pull/45382#discussion_r1514641048
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -145,6 +149,18 @@ public Collation(
}
}
+ /**
+ * Auxiliar
cloud-fan commented on code in PR #45382:
URL: https://github.com/apache/spark/pull/45382#discussion_r1514639021
##
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##
@@ -145,6 +149,18 @@ public Collation(
}
}
+ /**
+ * Auxiliar
uros-db commented on code in PR #45382:
URL: https://github.com/apache/spark/pull/45382#discussion_r1514612341
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -343,19 +346,33 @@ public boolean contains(final UTF8String substring) {
return
dbatomic commented on code in PR #45382:
URL: https://github.com/apache/spark/pull/45382#discussion_r1512945586
##
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java:
##
@@ -343,19 +346,33 @@ public boolean contains(final UTF8String substring) {
retur
