Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

HeartSaVioR closed pull request #45360: [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families URL: https://github.com/apache/spark/pull/45360 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

HeartSaVioR commented on PR #45360: URL: https://github.com/apache/spark/pull/45360#issuecomment-1990520156 Thanks! Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1520296947 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala: ## @@ -582,7 +636,7 @@ class RocksDBSuite extends AlsoTestWithChange

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1520296736 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala: ## @@ -536,6 +536,67 @@ class RocksDBSuite extends AlsoTestWithChang

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

HeartSaVioR commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1518475424 ## sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/RocksDBSuite.scala: ## @@ -582,7 +636,7 @@ class RocksDBSuite extends AlsoTestWithChangel

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

HeartSaVioR commented on PR #45360: URL: https://github.com/apache/spark/pull/45360#issuecomment-1985157244 Will review sooner than later. Maybe by today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

HyukjinKwon commented on PR #45360: URL: https://github.com/apache/spark/pull/45360#issuecomment-1984994353 Is this good to go? @HeartSaVioR @rangadi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1514964881 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -246,25 +246,35 @@ class RocksDB( colFamilyNameToHandleMap.cont

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1513631712 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -246,25 +246,35 @@ class RocksDB( colFamilyNameToHandleMap.cont

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1513624528 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -246,25 +246,35 @@ class RocksDB( colFamilyNameToHandleMap.cont

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

sahnib commented on code in PR #45360: URL: https://github.com/apache/spark/pull/45360#discussion_r1513594152 ## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDB.scala: ## @@ -246,25 +246,35 @@ class RocksDB( colFamilyNameToHandleMap.contains(c

Re: [PR] [SPARK-47250][SS] Add additional validations and NERF changes for RocksDB state provider and use of column families [spark]

anishshri-db commented on PR #45360: URL: https://github.com/apache/spark/pull/45360#issuecomment-1974249820 @sahnib @HeartSaVioR - PTAL, thx ! @HeartSaVioR - let me know if you are ok with the proposed dir layout changes and also if you prefer them in a separate PR. Thanks -- This