Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1617205925 ## sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala: ## @@ -432,11 +432,23 @@ trait AlterTableTests extends SharedSparkSession with

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

LuciferYang commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1616641862 ## sql/core/src/test/scala/org/apache/spark/sql/connector/AlterTableTests.scala: ## @@ -432,11 +432,23 @@ trait AlterTableTests extends SharedSparkSession with

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

LuciferYang commented on PR #46731: URL: https://github.com/apache/spark/pull/46731#issuecomment-2134258392 friendly ping @cloud-fan do you have any comments on this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613880314 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613124606 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613124606 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613088183 ## common/utils/src/main/resources/error/error-conditions.json: ## Review Comment: > We seem to lack a UT case related to `_LEGACY_ERROR_TEMP_1054`

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on PR #46731: URL: https://github.com/apache/spark/pull/46731#issuecomment-2128896002 > cc @MaxGekk @panbingkun FYI also cc @cloud-fan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613064843 ## common/utils/src/main/resources/error/error-conditions.json: ## Review Comment: We seem to lack a UT case related to `_LEGACY_ERROR_TEMP_1054` -- This

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613046446 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613046446 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -90,8 +91,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613027139 ## common/utils/src/main/resources/error/error-conditions.json: ## Review Comment: After the pr, Do we still need `_LEGACY_ERROR_TEMP_105[3-4]`? We should

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613022902 ## sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala: ## @@ -76,7 +76,8 @@ class ResolveSessionCatalog(val catalogManager:

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

panbingkun commented on code in PR #46731: URL: https://github.com/apache/spark/pull/46731#discussion_r1613020889 ## sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala: ## @@ -1333,30 +1333,34 @@ class PlanResolutionSuite extends

Re: [PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

LuciferYang commented on PR #46731: URL: https://github.com/apache/spark/pull/46731#issuecomment-2128783439 cc @MaxGekk @panbingkun FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-47257][SQL] Assign names to error classes _LEGACY_ERROR_TEMP_105[3-4] and _LEGACY_ERROR_TEMP_1113 [spark]

wayneguow opened a new pull request, #46731: URL: https://github.com/apache/spark/pull/46731 ### What changes were proposed in this pull request? This PR renames a few error classes related to usage of `ALTER COLUMN` errors: - _LEGACY_ERROR_TEMP_1053 =>