Re: [PR] [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits [spark]

2024-03-07 Thread via GitHub
yaooqinn commented on PR #45401: URL: https://github.com/apache/spark/pull/45401#issuecomment-1983276998 Merged to master. Thank you @cloud-fan @dongjoon-hyun @HyukjinKwon @MaxGekk -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits [spark]

2024-03-07 Thread via GitHub
yaooqinn closed pull request #45401: [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits URL: https://github.com/apache/spark/pull/45401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits [spark]

2024-03-07 Thread via GitHub
cloud-fan commented on code in PR #45401: URL: https://github.com/apache/spark/pull/45401#discussion_r1515795172 ## sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/StringUtilsSuite.scala: ## @@ -129,16 +129,6 @@ class StringUtilsSuite extends SparkFunSuite with

Re: [PR] [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits [spark]

2024-03-06 Thread via GitHub
dongjoon-hyun commented on PR #45401: URL: https://github.com/apache/spark/pull/45401#issuecomment-1982580157 It seems that the same failure (which @MaxGekk 's reported) still exists at the last CI. ``` StringUtilsSuite: [info] - escapeLikeRegex (1 millisecond) [info] - filter

Re: [PR] [SPARK-47300][SQL] `quoteIfNeeded` should quote identifier starts with digits [spark]

2024-03-06 Thread via GitHub
MaxGekk commented on PR #45401: URL: https://github.com/apache/spark/pull/45401#issuecomment-1980897588 How about deduplicate the tests: