Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-14 Thread via GitHub
dongjoon-hyun commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2054056965 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-14 Thread via GitHub
mridulm commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2054020151 Thanks @dongjoon-hyun ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-13 Thread via GitHub
dongjoon-hyun closed pull request #46014: [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices URL: https://github.com/apache/spark/pull/46014 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-13 Thread via GitHub
dongjoon-hyun commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2053805775 Merged to branch-3.5 for Apache Spark 3.5.2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-13 Thread via GitHub
dongjoon-hyun commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2053804650 While double-checking the PR, I'd realized that `3.4.3, 3.5.2` is better because the column name is `Since Version`. -- This is an automated message from the Apache Git Service.

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-13 Thread via GitHub
dongjoon-hyun commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2053803012 Yes, correct (https://github.com/apache/spark/pull/46014#discussion_r1561825387) > we will have to forward port that to master as well. -- This is an automated message from

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-12 Thread via GitHub
mridulm commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2052306349 Sounds good to me for docs @dongjoon-hyun - we will have to forward port that to master as well. And I guess we leave the config as 4.0 in code ? -- This is an automated message

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-12 Thread via GitHub
dongjoon-hyun commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2052103818 We can follow the Apache Spark Security page convention. - https://spark.apache.org/security.html > 3.2.2, or 3.3.1 or later In this case, maybe, `3.4.3, or 3.5.2 or

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-11 Thread via GitHub
mridulm commented on PR #46014: URL: https://github.com/apache/spark/pull/46014#issuecomment-2051007024 My concern with adding `3.4.3` was, that would typically mean it is available in `3.5.x` - but it wont, except for specific versions of `3.5`. Should we document it as such ? -- This

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-11 Thread via GitHub
dongjoon-hyun commented on code in PR #46014: URL: https://github.com/apache/spark/pull/46014#discussion_r1561825080 ## docs/security.md: ## @@ -169,6 +175,12 @@ The following table describes the different options available for configuring th 2.2.0 + +

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-11 Thread via GitHub
dongjoon-hyun commented on code in PR #46014: URL: https://github.com/apache/spark/pull/46014#discussion_r1561803406 ## docs/security.md: ## @@ -169,6 +175,12 @@ The following table describes the different options available for configuring th 2.2.0 + +

Re: [PR] [SPARK-47318][CORE][3.5] Adds HKDF round to AuthEngine key derivation to follow standard KEX practices [spark]

2024-04-11 Thread via GitHub
sweisdb commented on code in PR #46014: URL: https://github.com/apache/spark/pull/46014#discussion_r1561814424 ## docs/security.md: ## @@ -169,6 +175,12 @@ The following table describes the different options available for configuring th 2.2.0 + +