gengliangwang closed pull request #45926: [SPARK-47591][SQL] Hive-thriftserver:
Migrate logInfo with variables to structured logging framework
URL: https://github.com/apache/spark/pull/45926
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
gengliangwang commented on PR #45926:
URL: https://github.com/apache/spark/pull/45926#issuecomment-2063047503
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1569645171
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetSchemasOperation.scala:
##
@@ -49,7 +50,13 @@ private[hive] class
gengliangwang commented on PR #45926:
URL: https://github.com/apache/spark/pull/45926#issuecomment-2060387686
@itholic Please resolve the conflict so that I can merge this one. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
itholic commented on PR #45926:
URL: https://github.com/apache/spark/pull/45926#issuecomment-2053576659
Is there any way testing hive-thriftserver on local?
I tried couple of commands below:
```shell
build/sbt "sql/testOnly *ThriftServerWithSparkContextSuite"
build/sbt
gengliangwang commented on PR #45926:
URL: https://github.com/apache/spark/pull/45926#issuecomment-2052711109
@itholic The Hive-thriftserver tests failed. Please check it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
itholic commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1559179777
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala:
##
@@ -58,9 +59,12 @@ private[hive] class
panbingkun commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558992976
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala:
##
@@ -58,9 +59,12 @@ private[hive] class
panbingkun commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558978194
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##
@@ -126,7 +126,9 @@ private[hive] class
gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558922175
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala:
##
@@ -58,9 +59,12 @@ private[hive] class
gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558920991
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetCatalogsOperation.scala:
##
@@ -40,7 +41,7 @@ private[hive] class
gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558920135
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##
@@ -126,7 +126,9 @@ private[hive] class
gengliangwang commented on code in PR #45926:
URL: https://github.com/apache/spark/pull/45926#discussion_r1558919622
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkGetColumnsOperation.scala:
##
@@ -58,9 +59,12 @@ private[hive] class
itholic commented on PR #45926:
URL: https://github.com/apache/spark/pull/45926#issuecomment-2044219637
cc @panbingkun @gengliangwang @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
itholic opened a new pull request, #45926:
URL: https://github.com/apache/spark/pull/45926
### What changes were proposed in this pull request?
This PR proposes to migrate `logInfo` with variables of Hive-thriftserver
module to structured logging framework.
### Why are the
15 matches
Mail list logo
