Re: [PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-04-23 Thread via GitHub
cloud-fan commented on PR #45763: URL: https://github.com/apache/spark/pull/45763#issuecomment-2071482783 It has conflicts. @bersprockets can you help to create a 3.5 backport PR? thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-04-23 Thread via GitHub
cloud-fan closed pull request #45763: [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization URL: https://github.com/apache/spark/pull/45763 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-04-23 Thread via GitHub
cloud-fan commented on PR #45763: URL: https://github.com/apache/spark/pull/45763#issuecomment-2071478863 thanks, merging to master/3.5/3.4! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-04-21 Thread via GitHub
cloud-fan commented on code in PR #45763: URL: https://github.com/apache/spark/pull/45763#discussion_r1574118395 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala: ## @@ -2056,6 +2056,8 @@ case class LateralJoin(

Re: [PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-03-28 Thread via GitHub
HyukjinKwon commented on PR #45763: URL: https://github.com/apache/spark/pull/45763#issuecomment-2026517207 cc @allisonwang-db @maryannxue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] [SPARK-47633][SQL] Include right-side plan output in `LateralJoin#allAttributes` for more consistent canonicalization [spark]

2024-03-28 Thread via GitHub
bersprockets opened a new pull request, #45763: URL: https://github.com/apache/spark/pull/45763 ### What changes were proposed in this pull request? Modify `LateralJoin` to include right-side plan output in `allAttributes`. ### Why are the changes needed? In the