srielau commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1559602846
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -645,6 +646,34 @@ class CollationSuite extends DatasourceV2SQLBase with
mihailom-db commented on PR #45819:
URL: https://github.com/apache/spark/pull/45819#issuecomment-2042659387
If the collation is not important to the function execution we can create a
separate pattern for it where we will exclude parameters that do not need
casting. For example, substring
nikolamand-db commented on PR #45819:
URL: https://github.com/apache/spark/pull/45819#issuecomment-2042559655
How do we want to handle cases like string
[split](https://github.com/apache/spark/pull/45856/files#diff-8ce4728fc96a1a5f2a3a846470f03175ba00b61ff6bc51933883241e736d886aR548)
(work
mihailom-db commented on PR #45819:
URL: https://github.com/apache/spark/pull/45819#issuecomment-2042432922
@dbatomic @stefankandic @uros-db @stevomitric @nikolamand-db Could you take
a look at this PR? It introduces a new flag for collations and makes sure most
of the functions that
mihailom-db commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1555608196
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -645,6 +646,34 @@ class CollationSuite extends DatasourceV2SQLBase with
mihailom-db commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r142892
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -645,6 +646,34 @@ class CollationSuite extends DatasourceV2SQLBase with
HyukjinKwon commented on PR #45819:
URL: https://github.com/apache/spark/pull/45819#issuecomment-206686
Let's follow https://github.com/databricks/scala-style-guide, and remove
unrelated changes, e.g., adding newlines which makes
cherry-pick/backporting/reverting difficult.
--
This
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548778640
##
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##
@@ -509,6 +497,209 @@ class CollationSuite extends DatasourceV2SQLBase with
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548778507
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -20,57 +20,60 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548778237
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548778030
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548778372
##
sql/core/src/test/scala/org/apache/spark/sql/CollationStringExpressionsSuite.scala:
##
@@ -20,57 +20,60 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548777921
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r154888
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548777557
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548775474
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548776133
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##
@@ -733,7 +737,6 @@ abstract class TypeCoercionBase {
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548777342
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548777257
##
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##
@@ -20,421 +20,406 @@ package org.apache.spark.sql
import
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548774040
##
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548769446
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -76,8 +86,10 @@ class StringType private(val collationId: Int) extends
AtomicType
HyukjinKwon commented on code in PR #45819:
URL: https://github.com/apache/spark/pull/45819#discussion_r1548767671
##
sql/api/src/main/scala/org/apache/spark/sql/types/StringType.scala:
##
@@ -27,7 +34,10 @@ import org.apache.spark.sql.catalyst.util.CollationFactory
* @param
mihailom-db commented on PR #45819:
URL: https://github.com/apache/spark/pull/45819#issuecomment-2031925929
This PR merged in changes from https://github.com/apache/spark/pull/45383 in
order to build features faster.
--
This is an automated message from the Apache Git Service.
To respond
mihailom-db opened a new pull request, #45819:
URL: https://github.com/apache/spark/pull/45819
### What changes were proposed in this pull request?
Addition of priority flag to StringType.
### Why are the changes needed?
In order to follow casting rules for collations, we
24 matches
Mail list logo
